mongodb/mongo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SERVER-126510 Uncaught WriteConflictException in setFCVOnCleanStartup (#54036)

Browse Source 
GitOrigin-RevId: 1481c94ad5596ac45755cfd3318d3dca79591cbd
This commit is contained in:
Stephanie 2026-05-26 11:21:18 -04:00 committed by MongoDB Bot
parent 5ef24b85f5
commit f54d4c0e40
2 changed files with 21 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mongo/db/commands/BUILD.bazel
View File

@ -544,6 +544,7 @@ mongo_cc_library(
"//src/mongo/db/repl:repl_server_parameters",
"//src/mongo/db/repl:repl_settings",
"//src/mongo/db/shard_role",
"//src/mongo/db/shard_role/lock_manager:exception_util",
"//src/mongo/db/shard_role/shard_catalog:collection_options",
"//src/mongo/db/storage:storage_options",
],

36
src/mongo/db/commands/feature_compatibility_version.cpp
View File

@ -56,6 +56,7 @@
#include "mongo/db/server_options.h"
#include "mongo/db/server_parameter.h"
#include "mongo/db/service_context.h"
#include "mongo/db/shard_role/lock_manager/exception_util.h"
#include "mongo/db/shard_role/lock_manager/lock_manager_defs.h"
#include "mongo/db/shard_role/shard_catalog/catalog_raii.h"
#include "mongo/db/shard_role/shard_catalog/collection_catalog.h"
@ -654,24 +655,27 @@ Timestamp FeatureCompatibilityVersion::setIfCleanStartup(
CollectionOptions options;
options.uuid = UUID::gen();
uassertStatusOK(storageInterface->createCollection(opCtx, nss, options));
WriteUnitOfWork wuow(opCtx);
// Register a callback to update the timestamp on committing the FCV document.
if (term != repl::OpTime::kUninitializedTerm) {
shard_role_details::getRecoveryUnit(opCtx)->onCommit(
[&timestamp](OperationContext*, boost::optional<Timestamp> commitTime) {
if (commitTime) {
timestamp = *commitTime;
}
});
}
writeConflictRetry(opCtx, "setFCVOnCleanStartup", nss, [&] {
WriteUnitOfWork wuow(opCtx);
// We then insert the featureCompatibilityVersion document into the server configuration
// collection. The server parameter will be updated on commit by the op observer.
// Leave the timestamp empty to be populated by the OpObserver.
uassertStatusOK(storageInterface->insertDocument(
opCtx, nss, repl::TimestampedBSONObj{fcvDoc.toBSON(), Timestamp()}, term));
wuow.commit();
// Register a callback to update the timestamp on committing the FCV document.
if (term != repl::OpTime::kUninitializedTerm) {
shard_role_details::getRecoveryUnit(opCtx)->onCommit(
[&timestamp](OperationContext*, boost::optional<Timestamp> commitTime) {
if (commitTime) {
timestamp = *commitTime;
}
});
}
// We then insert the featureCompatibilityVersion document into the server configuration
// collection. The server parameter will be updated on commit by the op observer.
// Leave the timestamp empty to be populated by the OpObserver.
uassertStatusOK(storageInterface->insertDocument(
opCtx, nss, repl::TimestampedBSONObj{fcvDoc.toBSON(), Timestamp()}, term));
wuow.commit();
});
return timestamp;
};