mongodb/mongo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SERVER-127102 Simplify logic for onCommit in _insertKeysFromSideTableAndCommit (#54298)

Browse Source 
GitOrigin-RevId: 4759dcb4de29ae14cb744f5e5968fd183f0738d6
This commit is contained in:
Stephanie 2026-05-26 11:13:27 -04:00 committed by MongoDB Bot
parent 100b7b1459
commit 5ef24b85f5
1 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/mongo/db/index_builds/index_builds_coordinator.cpp
View File

@ -3954,22 +3954,10 @@ IndexBuildsCoordinator::CommitResult IndexBuildsCoordinator::_insertKeysFromSide
indexBuildsSSS.commit.addAndFetch(1);
storeLastCommittedDuration(*replState);
// TODO (SERVER-109664): Check build protocol rather than feature flag.
auto onCommitFn = [&](const std::vector<boost::optional<MultikeyPaths>>& multikeys) {
const bool isPdib = [&] {
if (replState->protocol == IndexBuildProtocol::kPrimaryDriven) {
return true;
}
if (replState->protocol != IndexBuildProtocol::kTwoPhase) {
return false;
}
auto fcvSnapshot = serverGlobalParams.featureCompatibility.acquireFCVSnapshot();
return fcvSnapshot.isVersionInitialized() &&
feature_flags::gFeatureFlagPrimaryDrivenIndexBuilds.isEnabled(
VersionContext::getDecoration(opCtx), fcvSnapshot);
}();
const bool shouldReplicate = isPdib && IndexBuildAction::kOplogCommit != action;
const bool shouldReplicate =
replState->protocol == IndexBuildProtocol::kPrimaryDriven &&
IndexBuildAction::kOplogCommit != action;
onCommitIndexBuild(opCtx,
collection->ns(),
replState,