pyca/bcrypt
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid Vec allocation when parsing salt

Browse Source 
Pull elements directly from the split iterator instead of collecting
into a Vec and using try_into.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Alex Gaynor 2026-02-17 19:06:48 -05:00
parent f9c24e9c12
commit f434c9851d
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/_bcrypt/src/lib.rs
View File

@ -91,12 +91,14 @@ fn hashpw<'p>(
// salt here is not just the salt bytes, but rather an encoded value
// containing a version number, number of rounds, and the salt.
// Should be [prefix, cost, hash]. This logic is copied from `bcrypt`
let [raw_version, raw_cost, remainder]: [&[u8]; 3] = salt
.split(|&b| b == b'$')
.filter(|s| !s.is_empty())
.collect::<Vec<_>>()
.try_into()
.map_err(|_| pyo3::exceptions::PyValueError::new_err("Invalid salt"))?;
let invalid_salt = || pyo3::exceptions::PyValueError::new_err("Invalid salt");
let mut parts = salt.split(|&b| b == b'$').filter(|s| !s.is_empty());
let raw_version = parts.next().ok_or_else(invalid_salt)?;
let raw_cost = parts.next().ok_or_else(invalid_salt)?;
let remainder = parts.next().ok_or_else(invalid_salt)?;
if parts.next().is_some() {
return Err(invalid_salt());
}
let version = match raw_version {
b"2y" => bcrypt::Version::TwoY,