SERVER-90610: Enable tidy check misc-unused-alias-decls (#22297)

GitOrigin-RevId: 0ad1fdc602207d30cd4386a18d8a64c7379709de

.clang-tidy.in

@@ -37,6 +37,7 @@ Checks:          '-*,
                   misc-static-assert,
                   misc-unconventional-assign-operator,
                   misc-uniqueptr-reset-release,
+                  misc-unused-alias-decls,
                   misc-unused-using-decls,
                   modernize-avoid-bind,
                   modernize-deprecated-headers,
@@ -119,7 +120,6 @@ Checks:          '-*,
                   -misc-redundant-expression,
                   -misc-throw-by-value-catch-by-reference,
                   -misc-unconventional-assign-operator,
-                  -misc-unused-alias-decls,
                   -modernize-use-bool-literals,
                   -modernize-use-emplace,
                   -modernize-use-noexcept,

src/mongo/client/sdam/sdam_json_test_runner.cpp

@@ -96,7 +96,6 @@
  */
 
 namespace fs = boost::filesystem;
-namespace moe = mongo::optionenvironment;
 using namespace mongo::sdam;
 
 namespace mongo::sdam {

src/mongo/client/sdam/server_selection_json_test_runner.cpp

@@ -101,7 +101,6 @@
  */
 
 namespace fs = boost::filesystem;
-namespace moe = mongo::optionenvironment;
 using namespace mongo::sdam;
 
 namespace mongo::sdam {

src/mongo/db/exec/update_stage.cpp

@@ -92,8 +92,6 @@
 
 namespace mongo {
 
-namespace mb = mutablebson;
-
 namespace {
 
 MONGO_FAIL_POINT_DEFINE(hangBeforeThrowWouldChangeOwningShard);

src/mongo/db/exec/upsert_stage.cpp

@@ -80,8 +80,6 @@ namespace mongo {
 
 MONGO_FAIL_POINT_DEFINE(hangBeforeUpsertPerformsInsert);
 
-namespace mb = mutablebson;
-
 namespace {
 
 const char idFieldName[] = "_id";

src/mongo/db/pipeline/document_source_graph_lookup.cpp

@@ -131,8 +131,6 @@ NamespaceString parseGraphLookupFromAndResolveNamespace(const BSONElement& elem,
 
 using boost::intrusive_ptr;
 
-namespace dps = ::mongo::dotted_path_support;
-
 std::unique_ptr<DocumentSourceGraphLookUp::LiteParsed> DocumentSourceGraphLookUp::LiteParsed::parse(
     const NamespaceString& nss, const BSONElement& spec) {
     uassert(ErrorCodes::FailedToParse,

src/mongo/db/pipeline/pipeline.cpp

@@ -185,8 +185,6 @@ using std::ostringstream;
 using std::string;
 using std::vector;
 
-namespace dps = ::mongo::dotted_path_support;
-
 using ChangeStreamRequirement = StageConstraints::ChangeStreamRequirement;
 using HostTypeRequirement = StageConstraints::HostTypeRequirement;
 using PositionRequirement = StageConstraints::PositionRequirement;

src/mongo/db/query/planner_access.cpp

@@ -102,7 +102,6 @@ namespace {
 using namespace mongo;
 
 namespace wcp = ::mongo::wildcard_planning;
-namespace dps = ::mongo::dotted_path_support;
 
 /**
  * Casts 'node' to a FetchNode* if it is a FetchNode, otherwise returns null.

src/mongo/db/query/planner_analysis.cpp

@@ -92,8 +92,6 @@ using std::string;
 using std::unique_ptr;
 using std::vector;
 
-namespace dps = ::mongo::dotted_path_support;
-
 //
 // Helpers for bounds explosion AKA quick-and-dirty SERVER-1205.
 //

src/mongo/db/query/query_planner.cpp

@@ -596,7 +596,6 @@ StatusWith<std::unique_ptr<QuerySolution>> tryToBuildSearchQuerySolution(
 
 using std::unique_ptr;
 
-namespace dps = ::mongo::dotted_path_support;
 // Copied verbatim from db/index.h
 static bool isIdIndex(const BSONObj& pattern) {
     BSONObjIterator i(pattern);

src/mongo/db/server_options_server_helpers.cpp

@@ -77,8 +77,6 @@
 using std::endl;
 using std::string;
 
-namespace moe = ::mongo::optionenvironment;
-
 namespace mongo {
 
 namespace {

src/mongo/executor/connection_pool_test.cpp

@@ -59,8 +59,6 @@ namespace mongo {
 namespace executor {
 namespace connection_pool_test_details {
 
-namespace m = unittest::match;
-
 class ConnectionPoolTest : public unittest::Test {
 public:
     constexpr static Milliseconds kNoTimeout = Milliseconds{-1};

src/mongo/unittest/golden_test.cpp

@@ -48,8 +48,6 @@
 
 namespace mongo::unittest {
 
-namespace fs = ::boost::filesystem;
-
 using namespace fmt::literals;
 
 void GoldenTestContext::printTestHeader(HeaderFormat format) {

src/mongo/unittest/unittest_test.cpp

@@ -68,7 +68,6 @@
 
 
 namespace {
-namespace stdx = mongo::stdx;
 namespace mus = mongo::unittest::stringify;
 
 bool containsPattern(const std::string& pattern, const std::string& value) {

src/mongo/util/net/ssl_options.cpp

@@ -47,7 +47,6 @@
 
 namespace mongo {
 
-namespace moe = mongo::optionenvironment;
 using std::string;
 
 SSLParams sslGlobalParams;