SERVER-115083 Mark as unfortunately_open the visibility of commands whose API and implementation reside in different modules (#45509)

GitOrigin-RevId: 64a0cbc254ace07d34fe21a84843e9aeefa66cfa
2025-12-19 14:54:16 +01:00 · 2025-12-19 14:54:16 +01:00 · a3a3c7e3f0
commit a3a3c7e3f0
parent 7ad2b92861
10 changed files with 34 additions and 27 deletions
--- a/modules_poc/modules.yaml
+++ b/modules_poc/modules.yaml
@ -287,8 +287,7 @@ catalog_and_routing.shard_role:
      bearing on the global catalog.
    slack: server-catalog-and-routing
    jira: Catalog and Routing
-    # TODO (SERVER-114537): Set this to `true` once all command definitions are tagged as `open`.
-    fully_marked: false
+    fully_marked: true
  files:
    - src/mongo/db/shard_role/**
    - src/mongo/db/service_entry_point_shard_role[._]*
--- a/src/mongo/db/shard_role/ddl/create.idl
+++ b/src/mongo/db/shard_role/ddl/create.idl
@ -30,9 +30,7 @@ global:
    cpp_namespace: "mongo"
    cpp_includes:
        - "mongo/db/shard_role/ddl/create_command_validation.h"
-    # TODO (SERVER-114537): Uncomment the mod_visibility below and tag the respective command
-    # definitions as 'open'
-    # mod_visibility: public
+    mod_visibility: public

 imports:
    - "mongo/crypto/encryption_fields.idl"
@ -227,6 +225,9 @@ commands:
                      action_type:
                          [remove, update, collStats, indexStats, planCacheRead]
        reply_type: CreateCommandReply
+        # TODO (SERVER-115805): Remove this module visibility override once this command’s API and
+        # implementation are part of the same module.
+        mod_visibility: unfortunately_open
        strict: true
        inline_chained_structs: true
        chained_structs:
--- a/src/mongo/db/shard_role/ddl/create_indexes.idl
+++ b/src/mongo/db/shard_role/ddl/create_indexes.idl
@ -28,9 +28,7 @@

 global:
    cpp_namespace: "mongo"
-    # TODO (SERVER-114537): Uncomment the mod_visibility below and tag the respective command
-    # definitions as 'open'
-    # mod_visibility: public
+    mod_visibility: public

 imports:
    - "mongo/db/auth/action_type.idl"
@ -205,6 +203,9 @@ commands:
                    resource_pattern: exact_namespace
                    action_type: createIndex
        reply_type: CreateIndexesReply
+        # TODO (SERVER-115805): Remove this module visibility override once this command’s API and
+        # implementation are part of the same module.
+        mod_visibility: unfortunately_open
        strict: true
        fields:
            v:
--- a/src/mongo/db/shard_role/ddl/drop.idl
+++ b/src/mongo/db/shard_role/ddl/drop.idl
@ -28,9 +28,7 @@

 global:
    cpp_namespace: "mongo"
-    # TODO (SERVER-114537): Uncomment the mod_visibility below and tag the respective command
-    # definitions as 'open'
-    # mod_visibility: public
+    mod_visibility: public

 imports:
    - "mongo/db/auth/action_type.idl"
@ -68,6 +66,9 @@ commands:
        strict: true
        api_version: "1"
        reply_type: DropReply
+        # TODO (SERVER-115805): Remove this module visibility override once this command’s API and
+        # implementation are part of the same module.
+        mod_visibility: unfortunately_open
        access_check:
            simple:
                privilege:
--- a/src/mongo/db/shard_role/ddl/drop_database.idl
+++ b/src/mongo/db/shard_role/ddl/drop_database.idl
@ -28,9 +28,7 @@

 global:
    cpp_namespace: "mongo"
-    # TODO (SERVER-114537): Uncomment the mod_visibility below and tag the respective command
-    # definitions as 'open'
-    # mod_visibility: public
+    mod_visibility: public

 imports:
    - "mongo/db/auth/action_type.idl"
@ -51,3 +49,6 @@ commands:
                    resource_pattern: exact_namespace
                    action_type: dropDatabase
        reply_type: OkReply
+        # TODO (SERVER-115805): Remove this module visibility override once this command’s API and
+        # implementation are part of the same module.
+        mod_visibility: unfortunately_open
--- a/src/mongo/db/shard_role/ddl/list_databases.idl
+++ b/src/mongo/db/shard_role/ddl/list_databases.idl
@ -27,9 +27,7 @@
 #
 global:
    cpp_namespace: "mongo"
-    # TODO (SERVER-114537): Uncomment the mod_visibility below and tag the respective command
-    # definitions as 'open'
-    # mod_visibility: public
+    mod_visibility: public

 imports:
    - "mongo/db/auth/access_checks.idl"
@ -103,3 +101,6 @@ commands:
                optional: true
                stability: stable
        reply_type: ListDatabasesReply
+        # TODO (SERVER-115805): Remove this module visibility override once this command’s API and
+        # implementation are part of the same module.
+        mod_visibility: unfortunately_open
--- a/src/mongo/db/shard_role/ddl/list_databases_for_all_tenants.idl
+++ b/src/mongo/db/shard_role/ddl/list_databases_for_all_tenants.idl
@ -27,9 +27,7 @@
 #
 global:
    cpp_namespace: "mongo"
-    # TODO (SERVER-114537): Uncomment the mod_visibility below and tag the respective command
-    # definitions as 'open'
-    # mod_visibility: public
+    mod_visibility: public

 imports:
    - "mongo/db/auth/access_checks.idl"
@ -102,3 +100,6 @@ commands:
                optional: true
                unstable: false
        reply_type: ListDatabasesForAllTenantsReply
+        # TODO (SERVER-115805): Remove this module visibility override once this command’s API and
+        # implementation are part of the same module.
+        mod_visibility: unfortunately_open
--- a/src/mongo/db/shard_role/ddl/list_indexes.idl
+++ b/src/mongo/db/shard_role/ddl/list_indexes.idl
@ -28,9 +28,7 @@

 global:
    cpp_namespace: "mongo"
-    # TODO (SERVER-114537): Uncomment the mod_visibility below and tag the respective command
-    # definitions as 'open'
-    # mod_visibility: public
+    mod_visibility: public

 imports:
    - "mongo/db/auth/access_checks.idl"
@ -253,3 +251,6 @@ commands:
                type: optionalBool
                stability: internal
        reply_type: ListIndexesReply
+        # TODO (SERVER-115805): Remove this module visibility override once this command’s API and
+        # implementation are part of the same module.
+        mod_visibility: unfortunately_open
--- a/src/mongo/db/shard_role/ddl/rename_collection.idl
+++ b/src/mongo/db/shard_role/ddl/rename_collection.idl
@ -28,9 +28,7 @@

 global:
    cpp_namespace: "mongo"
-    # TODO (SERVER-114537): Uncomment the mod_visibility below and tag the respective command
-    # definitions as 'open'
-    # mod_visibility: public
+    mod_visibility: public

 imports:
    - "mongo/db/auth/access_checks.idl"
@ -43,6 +41,9 @@ commands:
        command_name: renameCollection
        cpp_name: RenameCollectionCommand
        reply_type: ErrorReply
+        # TODO (SERVER-115805): Remove this module visibility override once this command’s API and
+        # implementation are part of the same module.
+        mod_visibility: unfortunately_open
        strict: true
        namespace: type
        type: namespacestring
--- a/src/mongo/db/shard_role/shard_catalog/index_catalog_mock.h
+++ b/src/mongo/db/shard_role/shard_catalog/index_catalog_mock.h
@ -40,7 +40,7 @@ namespace mongo {
 /**
 * This class comprises a mock IndexCatalog for use in unit tests.
 */
-class IndexCatalogMock : public IndexCatalog {
+class MONGO_MOD_NEEDS_REPLACEMENT IndexCatalogMock : public IndexCatalog {
 public:
    /**
     * Creates a cloned IndexCatalogMock.