SERVER-107767 Router should retry CreateIndexes on retriable errors (#38747)

GitOrigin-RevId: 1e3da12ceb8f0f2c01396d2d37d72655f8e918ad

jstests/concurrency/fsm_workloads/query/timeseries/find_cmd_with_indexes_timeseries.js

@@ -62,8 +62,7 @@ export const $config = (function() {
      * Checks that the createIndex cmd result either succeeded or failed in an acceptible manner.
      */
     function processCreateIndex(createIndexRes, indexSpec) {
-        assert(createIndexRes.ok == 1 || createIndexRes.code == ErrorCodes.IndexAlreadyExists ||
-                   createIndexRes.code == ErrorCodes.IndexBuildAborted ||
+        assert(createIndexRes.ok == 1 || createIndexRes.code == ErrorCodes.IndexBuildAborted ||
                    createIndexRes.code == ErrorCodes.NoMatchingDocument,
                "Create index for spec '" + indexSpec + "'failed: " + tojson(createIndexRes));
     }

jstests/libs/override_methods/network_error_and_txn_override.js

@@ -140,8 +140,7 @@ function isAcceptableRetryFailedResponse(cmdName, res) {
     // These codes are uniquely returned from user_management_commands.cpp
     const kErrorCodeRoleAlreadyExists = 51002;
     const kErrorCodeUserAlreadyExists = 51003;
-    return ((cmdName === "createIndexes" && res.code === ErrorCodes.IndexAlreadyExists) ||
-            (cmdName === "drop" && res.code === ErrorCodes.NamespaceNotFound) ||
+    return ((cmdName === "drop" && res.code === ErrorCodes.NamespaceNotFound) ||
             ((cmdName == "createUser") && (res.code === kErrorCodeUserAlreadyExists)) ||
             ((cmdName == "createRole") && (res.code === kErrorCodeRoleAlreadyExists)) ||
             ((cmdName === "dropIndexes" || cmdName === "deleteIndexes") &&

jstests/replsets/txn_override_unittests.js

@@ -942,23 +942,6 @@ const retryOnNetworkErrorTests = [
             assert.commandFailed(coll1.createIndex({x: 1}));
         }
     },
-    {
-        name: "raw response w/ only acceptable errors",
-        test: function() {
-            setCommandMockResponse("createIndexes", {
-                ok: 0,
-                code: ErrorCodes.IndexAlreadyExists,
-                raw: {
-                    shardOne: {code: ErrorCodes.IndexAlreadyExists, errmsg: "dummy"},
-                    shardTwo: {ok: 1},
-                    shardThree: {code: ErrorCodes.IndexAlreadyExists, errmsg: "dummy"}
-                }
-            });
-
-            assert.commandWorked(testDB.createCollection(collName1));
-            assert.commandWorked(coll1.createIndex({x: 1}));
-        }
-    },
     {
         name: "raw response w/ acceptable error and non-acceptable, non-retryable error",
         test: function() {

src/mongo/s/commands/cluster_create_indexes_cmd.cpp

@@ -157,7 +157,7 @@ public:
                     CommandHelpers::filterCommandRequestForPassthrough(
                         applyReadWriteConcern(opCtx, this, cmdToBeSent)),
                     ReadPreferenceSetting(ReadPreference::PrimaryOnly),
-                    Shard::RetryPolicy::kNoRetry,
+                    Shard::RetryPolicy::kIdempotent,
                     BSONObj() /*query*/,
                     BSONObj() /*collation*/,
                     boost::none /*letParameters*/,