diff --git a/.clang-tidy.in b/.clang-tidy.in index 48aab583a4a..48904483f56 100644 --- a/.clang-tidy.in +++ b/.clang-tidy.in @@ -98,7 +98,6 @@ Checks: '-*, -cert-err60-cpp, -cert-flp30-c, -clang-diagnostic-builtin-macro-redefined, - -clang-diagnostic-unknown-warning-option, -cppcoreguidelines-avoid-goto, -cppcoreguidelines-c-copy-assignment-signature, -cppcoreguidelines-interfaces-global-init, diff --git a/SConstruct b/SConstruct index ad17f2ab705..0360663fdcb 100644 --- a/SConstruct +++ b/SConstruct @@ -3933,10 +3933,6 @@ def doConfigure(myenv): # This warning overzealously warns on uses of non-virtual destructors which are benign. myenv.AddToCXXFLAGSIfSupported("-Wno-non-virtual-dtor") - # TODO(SERVER-97447): Remove this once we're fully on the v5 toolchain. In the meantime, we - # need to suppress some warnings that are only recognized by the new compilers. - myenv.AddToCXXFLAGSIfSupported("-Wno-unknown-warning-option") - # As of XCode 9, this flag must be present (it is not enabled # by -Wall), in order to enforce that -mXXX-version-min=YYY # will enforce that you don't use APIs from ZZZ. diff --git a/bazel/toolchains/mongo_cc_toolchain_config.bzl b/bazel/toolchains/mongo_cc_toolchain_config.bzl index 0da2409fd08..9adf815d7f4 100644 --- a/bazel/toolchains/mongo_cc_toolchain_config.bzl +++ b/bazel/toolchains/mongo_cc_toolchain_config.bzl @@ -772,7 +772,7 @@ def _impl(ctx): # inconsistent interference sizes between builds should not affect correctness. no_interference_size_warning_feature = feature( name = "no_interference_size_warning", - enabled = True, + enabled = ctx.attr.compiler == "gcc", flag_sets = [ flag_set( actions = all_cpp_compile_actions, @@ -781,20 +781,6 @@ def _impl(ctx): ], ) - # TODO(SERVER-97447): Remove this once we're fully on the v5 toolchain. - # In the meantime, we need to suppress some warnings that are only - # recognized by the new compilers. - no_unknown_warning_option_feature = feature( - name = "no_unknown_warning_option", - enabled = ctx.attr.compiler == "clang", - flag_sets = [ - flag_set( - actions = all_compile_actions, - flag_groups = [flag_group(flags = ["-Wno-unknown-warning-option"])], - ), - ], - ) - disable_warnings_for_third_party_libraries_clang_feature = feature( name = "disable_warnings_for_third_party_libraries_clang", enabled = ctx.attr.compiler == "clang", @@ -882,7 +868,6 @@ def _impl(ctx): no_invalid_offsetof_warning_feature, no_class_memaccess_warning_feature, no_interference_size_warning_feature, - no_unknown_warning_option_feature, disable_warnings_for_third_party_libraries_clang_feature, disable_warnings_for_third_party_libraries_gcc_feature, ] diff --git a/buildscripts/gdb/mongo.py b/buildscripts/gdb/mongo.py index fa3bb9158f3..c992e6789d4 100644 --- a/buildscripts/gdb/mongo.py +++ b/buildscripts/gdb/mongo.py @@ -20,7 +20,6 @@ def detect_toolchain(progspace): readelf_bin = "readelf" for path in [ "/opt/mongodbtoolchain/v5/bin/llvm-readelf", - "/opt/mongodbtoolchain/v4/bin/llvm-readelf", # TODO(SERVER-97447): Remove. ]: if os.path.exists(path): readelf_bin = path diff --git a/src/mongo/platform/compiler.h b/src/mongo/platform/compiler.h index 971ddf3896f..0415a42cce9 100644 --- a/src/mongo/platform/compiler.h +++ b/src/mongo/platform/compiler.h @@ -309,9 +309,7 @@ MONGO_COMPILER_IF_CLANG(MONGO_COMPILER_PRAGMA(clang diagnostic ignored w)) /** - * TODO(SERVER-97447): We ignore these warnings on GCC 14 to facilitate - * transition to the v5 toolchain. They should be investigated more deeply by - * the teams owning each callsite. + * TODO(SERVER-102303): Delete this macro once all its uses have been removed. */ #define MONGO_COMPILER_DIAGNOSTIC_IGNORED_TRANSITIONAL(w) \ MONGO_COMPILER_IF_GCC14(MONGO_COMPILER_DIAGNOSTIC_IGNORED(w)) diff --git a/src/mongo/util/future_util_test.cpp b/src/mongo/util/future_util_test.cpp index 8deab3012dc..600da7579e4 100644 --- a/src/mongo/util/future_util_test.cpp +++ b/src/mongo/util/future_util_test.cpp @@ -1382,7 +1382,7 @@ TEST_F(FutureUtilTest, WithCancellationWorksWithVoidInput) { ASSERT(cancelableFuture.isReady()); } -// TODO(SERVER-97447): One particular v5 buildvariant fails to build this test. +// TODO(SERVER-102282): One particular v5 buildvariant fails to build this test. #if !(!defined(__clang__) && defined(__x86_64__) && __GNUC__ >= 14) TEST_F(FutureUtilTest, WithCancellationWorksWithSemiFutureInput) { const int kResult{5};