From 7ea796140ec970f24f5ebf0f3e7c47faa650310c Mon Sep 17 00:00:00 2001 From: Mathias Stearn Date: Thu, 29 May 2025 12:16:15 +0200 Subject: [PATCH] SERVER-98435 disallow new unassigned files for finished teams (#36507) GitOrigin-RevId: 9ca5e76ae383a008bfdc201504394716dae026e6 --- modules_poc/mod_scanner.py | 7 +++++++ modules_poc/modules.yaml | 3 +++ 2 files changed, 10 insertions(+) diff --git a/modules_poc/mod_scanner.py b/modules_poc/mod_scanner.py index 7d5e1ff2fb4..4a24d09f254 100755 --- a/modules_poc/mod_scanner.py +++ b/modules_poc/mod_scanner.py @@ -917,6 +917,13 @@ def validate_modules() -> bool: for match in matches: seen_lines.add(match[1]) + if not matches: + teams = " and ".join(teams_for_file(path)) + if teams == "__NO_OWNER__" or teams == "server_catalog_and_routing": + continue # Only error for files owned by teams that have finished assignment. + perr(f"Error: {path} owned by {teams} doesn't match any globs in modules.yaml") + failed = True + if len(matches) <= 1: continue diff --git a/modules_poc/modules.yaml b/modules_poc/modules.yaml index 1ba64d08410..d9b79fef121 100644 --- a/modules_poc/modules.yaml +++ b/modules_poc/modules.yaml @@ -170,6 +170,7 @@ query: - src/mongo/db/op_observer/change_stream_pre_images_op_observer* - src/mongo/db/set_change_stream* - src/mongo/db/curop* + - src/mongo/db/cursor* - src/mongo/db/fts/ - src/mongo/db/geo/ - src/mongo/db/index_names* @@ -558,6 +559,7 @@ routing_and_topology: # are stored in the config server and are replicated to all shards. They are used to control # the behavior of the cluster as a whole, rather than individual shards. - src/mongo/db/commands/*cluster_parameter* + - src/mongo/db/commands/cluster_server_parameter* - src/mongo/db/s/config/*cluster_parameter* - src/mongo/db/s/shardsvr_set_cluster_parameter_command.cpp - src/mongo/idl/cluster_server_parameter* @@ -617,6 +619,7 @@ routing_and_topology: # user writes block - src/mongo/db/commands/*user_write_block* + - src/mongo/db/op_observer/*user_write_block* - src/mongo/db/write_block_bypass[._]* - src/mongo/db/s/*user_write* - src/mongo/db/s/config/*user_write*