mongodb/mongo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SERVER-119552: Fix view resolution check for extensions (#48269)

Browse Source 
GitOrigin-RevId: 430700e8c31fb7e6ef88a46f25982be0cf731315
This commit is contained in:
Mariano Shaar 2026-02-18 15:37:24 -05:00 committed by MongoDB Bot
parent a4298e2cd1
commit 54a1582c93
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/mongo/db/pipeline/search/search_helper_bson_obj.h
View File

@ -61,6 +61,32 @@ inline bool hasMongotExtension(const auto& extensionNames) {
} // namespace detail
/**
* Checks that the pipeline isn't empty and if the first stage in the pipeline is the $vectorSearch
* extension stage. The legacy stage returns false.
*
* TODO SERVER-117168 Remove this function.
*/
inline bool isExtensionVectorSearchPipeline(
const std::shared_ptr<IncrementalFeatureRolloutContext>& ifrContext,
const std::vector<BSONObj>& pipeline) {
if (pipeline.empty()) {
return false;
}
const auto& firstStageBson = pipeline[0];
using detail::is;
if (is<DocumentSourceVectorSearch>(firstStageBson)) {
// Note we don't need to worry about/consult 'featureFlagExtensionViewsAndUnionWith'
// because the extension will enforce this behavior by toggling
// 'gFeatureFlagVectorSearchExtension' and retrying, so thankfully this is enough, and
// we don't need to understand what context this BSON appears in (w.r.t. views or
// sub-pipelines).
return ifrContext->getSavedFlagValue(feature_flags::gFeatureFlagVectorSearchExtension) &&
detail::hasMongotExtension(serverGlobalParams.extensions);
}
return false;
}
/**
* Checks that the pipeline isn't empty and if the first stage in the pipeline is a mongot stage
* Namely, that includes:

3
src/mongo/db/views/pipeline_resolver.cpp
View File

@ -71,7 +71,8 @@ std::vector<BSONObj> buildResolvedPipelineForSimpleCase(
// Mongot user pipelines are a unique case: $_internalSearchIdLookup applies the view pipeline.
// For this reason, we do not expand the aggregation request to include the view pipeline.
// Caller is expected to use LiteParsedPipeline::handleView() for such cases.
if (search_helper_bson_obj::isMongotPipeline(ifrContext, userPipeline)) {
if (search_helper_bson_obj::isMongotPipeline(ifrContext, userPipeline) ||
search_helper_bson_obj::isExtensionVectorSearchPipeline(ifrContext, userPipeline)) {
return userPipeline;
}