mongodb/mongo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SERVER-110832 Oplog writer should not hold on to session through rollbacks (#43643)

Browse Source 
GitOrigin-RevId: d30b6856465084805ccffbb393bf067a08dadaea
This commit is contained in:
gitpushjoe 2025-11-10 10:54:56 -05:00 committed by MongoDB Bot
parent d7a239f410
commit 47e6b69dce
1 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/mongo/db/repl/oplog_writer_impl.cpp
View File

@ -201,15 +201,28 @@ void OplogWriterImpl::_run() {
invariant(!_replCoord->getMemberState().arbiter());
const auto flushJournal = !getGlobalServiceContext()->getStorageEngine()->isEphemeral();
const auto opCtxHolder = cc().makeOperationContext();
auto opCtx = opCtxHolder.get();
ServiceContext::UniqueOperationContext opCtxHolder;
OperationContext* opCtx = nullptr;
// Oplog writes are crucial to the stability of the replica set. We give the operations
// Immediate priority so that it skips waiting for ticket acquisition and flow control.
ScopedAdmissionPriority<ExecutionAdmissionContext> priority(
opCtx, AdmissionContext::Priority::kExempt);
boost::optional<ScopedAdmissionPriority<ExecutionAdmissionContext>> priority;
const auto resetOpCtx = [&] {
priority.reset();
opCtxHolder.reset();
opCtxHolder = cc().makeOperationContext();
opCtx = opCtxHolder.get();
priority.emplace(opCtx, AdmissionContext::Priority::kExempt);
};
resetOpCtx();
// TODO(SERVER-110834): Revisit the opCtx refresh timing wrt leaking cursors.
while (true) {
// For pausing replication in tests.
if (MONGO_unlikely(rsSyncApplyStop.shouldFail())) {
LOGV2(8543102,
@ -231,8 +244,12 @@ void OplogWriterImpl::_run() {
continue;
}
// Extract the opTime and wallTime of the last op in the batch.
auto ops = batch.releaseBatch();
// Reset and reacquire the opCtxHolder and scoped admission priority.
resetOpCtx();
// Extract the opTime and wallTime of the last op in the batch.
auto lastOpTimeAndWallTime =
invariantStatusOK(OpTimeAndWallTime::parseOpTimeAndWallTimeFromOplogEntry(ops.back()));