mongodb/mongo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SERVER-127288 Split up MultiIndexBlock::_constructStateObject (#54161)

Browse Source 
GitOrigin-RevId: cff8bfce3fac53cd3c71cd7d46d8e4fbdd0ad0a2
This commit is contained in:
Gregory Noma 2026-05-21 12:54:44 -04:00 committed by MongoDB Bot
parent edc5fa4a70
commit 45b22ebdc8
2 changed files with 68 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

116
src/mongo/db/index_builds/multi_index_block.cpp
View File

@ -1650,7 +1650,7 @@ void MultiIndexBlock::_writeStateToContainer(OperationContext* opCtx) const {
"details"_attr = obj);
}
BSONObj MultiIndexBlock::_constructStateObject() const {
ResumeIndexInfo MultiIndexBlock::_buildResumeIndexInfo() const {
ResumeIndexInfo resumeIndexInfo;
resumeIndexInfo.setBuildUUID(*_buildUUID);
resumeIndexInfo.setPhase(_phase);
@ -1665,59 +1665,71 @@ BSONObj MultiIndexBlock::_constructStateObject() const {
resumeIndexInfo.setCollectionScanPosition(_lastRecordIdInserted);
}
return resumeIndexInfo;
}
IndexStateInfo MultiIndexBlock::_buildIndexStateInfo(const IndexToBuild& index) const {
IndexStateInfo indexStateInfo;
if (_phase != IndexBuildPhaseEnum::kDrainWrites) {
switch (_containerWriteBehavior) {
case ContainerWriteBehavior::kDoNotReplicate: {
// Persist the data to disk so that we see all of the data that has been inserted
// into the Sorter.
indexStateInfo = index.bulk->persistDataForShutdown();
break;
}
case ContainerWriteBehavior::kReplicate: {
// When replicating container writes, the persisted state is written via a callback
// that is run when a spill occurs. So, we can simply get persisted state without
// forcing another spill.
indexStateInfo = index.bulk->getPersistedState();
break;
}
}
}
if (_phase == IndexBuildPhaseEnum::kCollectionScan) {
indexStateInfo.setLastSpilledRecordId(index.lastSpilledRecordId);
}
auto& indexBuildInfo = index.block->getIndexBuildInfo();
indexStateInfo.setSideWritesTable(*indexBuildInfo.sideWritesIdent);
indexStateInfo.setSkippedRecordTrackerTable(*indexBuildInfo.skippedRecordsIdent);
// For compatibility with v8.0, the constraintViolationsIdent is not persisted in the resume
// state if the index is not unique given that version used to check explicitly for this case
// and fail otherwise.
if (index.block->getSpec()["unique"].trueValue()) {
if (auto& duplicateKeyTrackerIdent = indexBuildInfo.constraintViolationsIdent) {
indexStateInfo.setDuplicateKeyTrackerTable(*duplicateKeyTrackerIdent);
}
}
indexStateInfo.setSpec(index.block->getSpec());
indexStateInfo.setIsMultikey(index.bulk->isMultikey());
std::vector<MultikeyPath> multikeyPaths;
for (const auto& multikeyPath : index.bulk->getMultikeyPaths()) {
MultikeyPath multikeyPathObj;
std::vector<int32_t> multikeyComponents;
for (const auto& multikeyComponent : multikeyPath) {
multikeyComponents.emplace_back(multikeyComponent);
}
multikeyPathObj.setMultikeyComponents(std::move(multikeyComponents));
multikeyPaths.emplace_back(std::move(multikeyPathObj));
}
indexStateInfo.setMultikeyPaths(std::move(multikeyPaths));
return indexStateInfo;
}
BSONObj MultiIndexBlock::_constructStateObject() const {
auto resumeIndexInfo = _buildResumeIndexInfo();
std::vector<IndexStateInfo> indexInfos;
indexInfos.reserve(_indexes.size());
for (const auto& index : _indexes) {
IndexStateInfo indexStateInfo;
if (_phase != IndexBuildPhaseEnum::kDrainWrites) {
switch (_containerWriteBehavior) {
case ContainerWriteBehavior::kDoNotReplicate: {
// Persist the data to disk so that we see all of the data that has been
// inserted into the Sorter.
indexStateInfo = index.bulk->persistDataForShutdown();
break;
}
case ContainerWriteBehavior::kReplicate: {
// When replicating container writes, the persisted state is written via a
// callback that is run when a spill occurs. So, we can simply get persisted
// state without forcing another spill.
indexStateInfo = index.bulk->getPersistedState();
break;
}
}
}
if (_phase == IndexBuildPhaseEnum::kCollectionScan) {
indexStateInfo.setLastSpilledRecordId(index.lastSpilledRecordId);
}
auto& indexBuildInfo = index.block->getIndexBuildInfo();
indexStateInfo.setSideWritesTable(*indexBuildInfo.sideWritesIdent);
indexStateInfo.setSkippedRecordTrackerTable(*indexBuildInfo.skippedRecordsIdent);
// For compatibility with v8.0, the constraintViolationsIdent is not persisted in the
// resume state if the index is not unique given that version used to check explicitly for
// this case and fail otherwise.
if (index.block->getSpec()["unique"].trueValue()) {
if (auto& duplicateKeyTrackerIdent = indexBuildInfo.constraintViolationsIdent) {
indexStateInfo.setDuplicateKeyTrackerTable(*duplicateKeyTrackerIdent);
}
}
indexStateInfo.setSpec(index.block->getSpec());
indexStateInfo.setIsMultikey(index.bulk->isMultikey());
std::vector<MultikeyPath> multikeyPaths;
for (const auto& multikeyPath : index.bulk->getMultikeyPaths()) {
MultikeyPath multikeyPathObj;
std::vector<int32_t> multikeyComponents;
for (const auto& multikeyComponent : multikeyPath) {
multikeyComponents.emplace_back(multikeyComponent);
}
multikeyPathObj.setMultikeyComponents(std::move(multikeyComponents));
multikeyPaths.emplace_back(std::move(multikeyPathObj));
}
indexStateInfo.setMultikeyPaths(std::move(multikeyPaths));
indexInfos.emplace_back(std::move(indexStateInfo));
indexInfos.emplace_back(_buildIndexStateInfo(index));
}
resumeIndexInfo.setIndexes(std::move(indexInfos));

4
src/mongo/db/index_builds/multi_index_block.h
View File

@ -372,6 +372,10 @@ private:
BSONObj _constructStateObject() const;
ResumeIndexInfo _buildResumeIndexInfo() const;
IndexStateInfo _buildIndexStateInfo(const IndexToBuild& index) const;
Status _failPointHangDuringBuild(OperationContext* opCtx,
FailPoint* fp,
StringData where,