mongodb/mongo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SERVER-127488 fix single-char StringData::find calls (#54402)

Browse Source 
GitOrigin-RevId: 68e4068306280eee5fb3a9063d2217a8366ad5ac
This commit is contained in:
Billy Donahue 2026-05-26 14:30:15 -04:00 committed by MongoDB Bot
parent d81e12fc17
commit 0966c1e4b1
7 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mongo/db/index/btree_key_generator.cpp
View File

@ -77,7 +77,7 @@ std::pair<BSONElement, bool> extractNonArrayElementAtPath(const BSONObj& obj, St
static const auto kEmptyElt = BSONElement{};
auto&& [elt, tail] = [&]() -> std::pair<BSONElement, StringData> {
if (auto dotOffset = path.find("."); dotOffset != std::string::npos) {
if (auto dotOffset = path.find('.'); dotOffset != std::string::npos) {
return {obj.getField(path.substr(0, dotOffset)), path.substr(dotOffset + 1)};
}
return {obj.getField(path), ""_sd};

4
src/mongo/db/query/query_tester/test.cpp
View File

@ -294,7 +294,7 @@ Test Test::parseTest(std::fstream& fs,
} else {
auto sd = StringData{lineFromFile};
{
auto endDocument = sd.rfind("}");
auto endDocument = sd.rfind('}');
if (endDocument == std::string::npos) {
continue;
}
@ -303,7 +303,7 @@ Test Test::parseTest(std::fstream& fs,
sd.remove_suffix(sd.size() - endDocument - 1);
}
{
auto startDocument = sd.find("{");
auto startDocument = sd.find('{');
if (startDocument == std::string::npos) {
continue;
}

2
src/mongo/db/s/analyze_shard_key_read_write_distribution_stage.cpp
View File

@ -264,7 +264,7 @@ void processSampledDiffs(OperationContext* opCtx,
size_t startIndex = 0;
while (startIndex < shardKeyFieldName.size()) {
const size_t lastDotIndex = shardKeyFieldName.find(".", startIndex);
const size_t lastDotIndex = shardKeyFieldName.find('.', startIndex);
if (lastDotIndex == std::string::npos) {
break;
}

2
src/mongo/db/shard_role/shard_catalog/create_collection.cpp
View File

@ -147,7 +147,7 @@ Status validateClusteredIndexSpec(OperationContext* opCtx,
}
const auto arbitraryClusterKeyField = clustered_util::getClusterKeyFieldName(spec);
if (arbitraryClusterKeyField.find(".", 0) != std::string::npos) {
if (arbitraryClusterKeyField.find('.', 0) != std::string::npos) {
return Status(
ErrorCodes::Error(6053701),
"The clusteredIndex option does not support a cluster key with nested fields");

2
src/mongo/platform/decimal128.cpp
View File

@ -513,7 +513,7 @@ std::string Decimal128::toString() const {
StringData dec128String(decimalCharRepresentation);
int ePos = dec128String.find("E");
int ePos = dec128String.find('E');
// Calculate the precision and exponent of the number and output it in a readable manner
int precision = 0;

2
src/mongo/unittest/unittest_main_core.cpp
View File

@ -179,7 +179,7 @@ bool matchesGoogleFilter(StringData filt, StringData suite, StringData test) {
filt.remove_prefix(1);
continue;
}
size_t pos = filt.find_first_of(":");
size_t pos = filt.find_first_of(':');
StringData elem = filt.substr(0, pos);
filt = filt.substr(pos);
if (matchesGooglePattern(elem, fullName))

2
src/mongo/util/net/http_client_curl.cpp
View File

@ -644,7 +644,7 @@ HostAndPort exactHostAndPortFromUrl(StringData url) {
url = url.substr(slashesIndex + slashes.size());
if (url.find('/') != std::string::npos) {
url = url.substr(0, url.find("/"));
url = url.substr(0, url.find('/'));
}
auto hp = HostAndPort(url);