From 98dcaa2363346b0cb78256eb0d826b9fa9dc41cb Mon Sep 17 00:00:00 2001 From: Bernie Hackett Date: Wed, 2 Mar 2016 16:25:50 -0500 Subject: [PATCH] PYTHON-1056 - Disallow double quotes in database names --- pymongo/database.py | 2 +- test/test_database.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pymongo/database.py b/pymongo/database.py index 049ec1152..3f22f7f24 100644 --- a/pymongo/database.py +++ b/pymongo/database.py @@ -41,7 +41,7 @@ def _check_name(name): if not name: raise InvalidName("database name cannot be the empty string") - for invalid_char in [" ", ".", "$", "/", "\\", "\x00"]: + for invalid_char in [' ', '.', '$', '/', '\\', '\x00', '"']: if invalid_char in name: raise InvalidName("database names cannot contain the " "character %r" % invalid_char) diff --git a/test/test_database.py b/test/test_database.py index d1f465663..5ad199ae9 100644 --- a/test/test_database.py +++ b/test/test_database.py @@ -71,6 +71,7 @@ class TestDatabaseNoConnect(unittest.TestCase): def test_name(self): self.assertRaises(TypeError, Database, self.client, 4) self.assertRaises(InvalidName, Database, self.client, "my db") + self.assertRaises(InvalidName, Database, self.client, 'my"db') self.assertRaises(InvalidName, Database, self.client, "my\x00db") self.assertRaises(InvalidName, Database, self.client, u("my\u0000db"))