From 8021c75932f7de2c80da407dc489a8d6d58e072f Mon Sep 17 00:00:00 2001 From: behackett Date: Fri, 6 May 2011 10:36:13 -0700 Subject: [PATCH] Catch only UnicodeError for string decode failure. The default exception (which we use) for decode failures is UnicodeError or a subclass of it. This fixes a unittest that forces RuntimeError. We shouldn't use blanket except blocks either way. --- bson/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bson/__init__.py b/bson/__init__.py index 3a89d7a78..9659166a1 100644 --- a/bson/__init__.py +++ b/bson/__init__.py @@ -87,7 +87,7 @@ def _make_c_string(string, check_null=False): try: string.decode("utf-8") return string + "\x00" - except: + except UnicodeError: raise InvalidStringData("strings in documents must be valid " "UTF-8: %r" % string)