mongodb/mongo-python-driver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PYTHON-346 - Eliminate _get_int unsigned option

Browse Source 
This cleans up a few pylint complaints and provides a
small perf improvement.
This commit is contained in:
Bernie Hackett 2014-08-20 11:30:12 -07:00
parent 8dc79d1b30
commit 74f55a283a
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
bson/__init__.py
View File

@ -91,10 +91,9 @@ BSONMIN = b"\xFF" # Min key
BSONMAX = b"\x7F" # Max key
def _get_int(data, position, dummy, unsigned=False):
format = unsigned and "I" or "i"
def _get_int(data, position, dummy):
try:
value = struct.unpack("<%s" % format, data[position:position + 4])[0]
value = struct.unpack("<i", data[position:position + 4])[0]
except struct.error:
raise InvalidBSON()
position += 4
@ -284,10 +283,9 @@ def _get_ref(data, position, opts):
return DBRef(collection, oid), position
def _get_timestamp(data, position, opts):
inc, position = _get_int(data, position, opts, unsigned=True)
timestamp, position = _get_int(data, position, opts, unsigned=True)
return Timestamp(timestamp, inc), position
def _get_timestamp(data, position, dummy):
inc, timestamp = struct.unpack("<II", data[position:position + 8])
return Timestamp(timestamp, inc), position + 8
def _get_long(data, position, dummy):