mongodb/mongo-python-driver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PYTHON-712 ObjectId.is_valid(None) should be False.

Browse Source
This commit is contained in:
A. Jesse Jiryu Davis 2014-06-18 16:19:58 -04:00
parent c99fdccab3
commit 504c5a9889
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bson/objectid.py
View File

@ -139,6 +139,9 @@ class ObjectId(object):
.. versionadded:: 2.3
"""
if not oid:
return False
try:
ObjectId(oid)
return True

1
test/test_objectid.py
View File

@ -176,6 +176,7 @@ class TestObjectId(unittest.TestCase):
self.assertEqual(oid_1_9, oid_1_10)
def test_is_valid(self):
self.assertFalse(ObjectId.is_valid(None))
self.assertFalse(ObjectId.is_valid(4))
self.assertFalse(ObjectId.is_valid(175.0))
self.assertFalse(ObjectId.is_valid({"test": 4}))