From 3ebd93480a8e66be27163c86aa87f01762e55f4a Mon Sep 17 00:00:00 2001 From: Iris <58442094+sleepyStick@users.noreply.github.com> Date: Mon, 25 Aug 2025 08:54:10 -0700 Subject: [PATCH] PYTHON-5514 Specific assertions for "is" and "is not None" (#2502) --- test/asynchronous/test_collection.py | 2 +- test/asynchronous/test_session.py | 6 +++--- test/test_collection.py | 2 +- test/test_session.py | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/asynchronous/test_collection.py b/test/asynchronous/test_collection.py index 6a85b6396..90a051853 100644 --- a/test/asynchronous/test_collection.py +++ b/test/asynchronous/test_collection.py @@ -1319,7 +1319,7 @@ class AsyncTestCollection(AsyncIntegrationTest): self.assertIn(exc.code, (9, 10147, 16840, 17009)) # Just check that we set the error document. Fields # vary by MongoDB version. - self.assertTrue(exc.details is not None) + self.assertIsNotNone(exc.details) else: self.fail("OperationFailure was not raised") diff --git a/test/asynchronous/test_session.py b/test/asynchronous/test_session.py index 5ed359775..19ce868c5 100644 --- a/test/asynchronous/test_session.py +++ b/test/asynchronous/test_session.py @@ -378,9 +378,9 @@ class TestSession(AsyncIntegrationTest): async with self.client.start_session() as s: cursor = coll.find(session=s) - self.assertTrue(cursor.session is s) + self.assertIs(cursor.session, s) clone = cursor.clone() - self.assertTrue(clone.session is s) + self.assertIs(clone.session, s) # No explicit session. cursor = coll.find(batch_size=2) @@ -392,7 +392,7 @@ class TestSession(AsyncIntegrationTest): await anext(clone) self.assertIsNone(clone.session) self.assertIsNotNone(clone._session) - self.assertFalse(cursor._session is clone._session) + self.assertIsNot(cursor._session, clone._session) await cursor.close() await clone.close() diff --git a/test/test_collection.py b/test/test_collection.py index 0dce88423..b1947259b 100644 --- a/test/test_collection.py +++ b/test/test_collection.py @@ -1305,7 +1305,7 @@ class TestCollection(IntegrationTest): self.assertIn(exc.code, (9, 10147, 16840, 17009)) # Just check that we set the error document. Fields # vary by MongoDB version. - self.assertTrue(exc.details is not None) + self.assertIsNotNone(exc.details) else: self.fail("OperationFailure was not raised") diff --git a/test/test_session.py b/test/test_session.py index 16a219ae5..40d0a53af 100644 --- a/test/test_session.py +++ b/test/test_session.py @@ -378,9 +378,9 @@ class TestSession(IntegrationTest): with self.client.start_session() as s: cursor = coll.find(session=s) - self.assertTrue(cursor.session is s) + self.assertIs(cursor.session, s) clone = cursor.clone() - self.assertTrue(clone.session is s) + self.assertIs(clone.session, s) # No explicit session. cursor = coll.find(batch_size=2) @@ -392,7 +392,7 @@ class TestSession(IntegrationTest): next(clone) self.assertIsNone(clone.session) self.assertIsNotNone(clone._session) - self.assertFalse(cursor._session is clone._session) + self.assertIsNot(cursor._session, clone._session) cursor.close() clone.close()