From 2f301ea7c02d2b90cf6ddd77608c34d67b1f12e0 Mon Sep 17 00:00:00 2001 From: Jib Date: Wed, 1 Apr 2026 11:20:15 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Jib --- bson/buffer.c | 1 - pymongo/_cmessagemodule.c | 7 +++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/bson/buffer.c b/bson/buffer.c index d96f7218c..cc7520274 100644 --- a/bson/buffer.c +++ b/bson/buffer.c @@ -155,4 +155,3 @@ char* pymongo_buffer_get_buffer(buffer_t buffer) { void pymongo_buffer_update_position(buffer_t buffer, buffer_position new_position) { buffer->position = new_position; } - diff --git a/pymongo/_cmessagemodule.c b/pymongo/_cmessagemodule.c index c2b354046..1597652d6 100644 --- a/pymongo/_cmessagemodule.c +++ b/pymongo/_cmessagemodule.c @@ -333,6 +333,7 @@ fail: return result; } + static void _set_document_too_large(int size, long max) { PyObject* DocumentTooLarge = _error("DocumentTooLarge"); @@ -351,6 +352,7 @@ _set_document_too_large(int size, long max) { #define _DELETE 2 /* OP_MSG ----------------------------------------------- */ + static int _batched_op_msg( unsigned char op, unsigned char ack, @@ -656,6 +658,7 @@ fail: } /* End OP_MSG -------------------------------------------- */ + static int _batched_write_command( char* ns, Py_ssize_t ns_len, unsigned char op, @@ -859,6 +862,7 @@ fail: Py_XDECREF(iterator); return 0; } + static PyObject* _cbson_encode_batched_write_command(PyObject* self, PyObject* args) { char *ns = NULL; @@ -1013,6 +1017,7 @@ fail: INITERROR; } + static PyModuleDef_Slot _cmessage_slots[] = { {Py_mod_exec, _cmessage_exec}, #ifdef Py_MOD_MULTIPLE_INTERPRETERS_SUPPORTED @@ -1024,6 +1029,7 @@ static PyModuleDef_Slot _cmessage_slots[] = { {0, NULL}, }; + static struct PyModuleDef moduledef = { PyModuleDef_HEAD_INIT, "_cmessage", @@ -1040,3 +1046,4 @@ PyMODINIT_FUNC PyInit__cmessage(void) { return PyModuleDef_Init(&moduledef); +}