From 27a232cd40bb153a52103b9faf07ff501a8cbff8 Mon Sep 17 00:00:00 2001 From: Bernie Hackett Date: Wed, 2 Mar 2016 16:38:02 -0500 Subject: [PATCH] PYTHON-1056 - Disallow double quotes in database names --- pymongo/helpers.py | 2 +- test/test_database.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pymongo/helpers.py b/pymongo/helpers.py index ae88e7b62..3be4527d9 100644 --- a/pymongo/helpers.py +++ b/pymongo/helpers.py @@ -263,7 +263,7 @@ def _check_database_name(name): if not name: raise InvalidName("database name cannot be the empty string") - for invalid_char in [" ", ".", "$", "/", "\\", "\x00"]: + for invalid_char in [' ', '.', '$', '/', '\\', '\x00', '"']: if invalid_char in name: raise InvalidName("database names cannot contain the " "character %r" % invalid_char) diff --git a/test/test_database.py b/test/test_database.py index cf6983b89..ec4e895f5 100644 --- a/test/test_database.py +++ b/test/test_database.py @@ -68,6 +68,7 @@ class TestDatabase(unittest.TestCase): def test_name(self): self.assertRaises(TypeError, Database, self.client, 4) self.assertRaises(InvalidName, Database, self.client, "my db") + self.assertRaises(InvalidName, Database, self.client, 'my"db') self.assertRaises(InvalidName, Database, self.client, "my\x00db") self.assertRaises(InvalidName, Database, self.client, u"my\u0000db")