From f653b2f0cf5aea2a3ad179e5858f248e975d68f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Date: Fri, 10 Nov 2023 16:07:05 +0100 Subject: [PATCH] Inline Brotli samples in tests (#2935) Inline the compressed Brotli samples in tests to make them independent of Brotli implementation. This makes it possible to run the test suite both against Brotli and brotlicffi. Fixes #2906 --- tests/test_decoders.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/test_decoders.py b/tests/test_decoders.py index d71e9a83..61c9a4ac 100644 --- a/tests/test_decoders.py +++ b/tests/test_decoders.py @@ -1,7 +1,6 @@ import typing import zlib -import brotli import chardet import pytest @@ -61,7 +60,7 @@ def test_gzip(): def test_brotli(): body = b"test 123" - compressed_body = brotli.compress(body) + compressed_body = b"\x8b\x03\x80test 123\x03" headers = [(b"Content-Encoding", b"br")] response = httpx.Response( @@ -94,7 +93,7 @@ def test_multi(): def test_multi_with_identity(): body = b"test 123" - compressed_body = brotli.compress(body) + compressed_body = b"\x8b\x03\x80test 123\x03" headers = [(b"Content-Encoding", b"br, identity")] response = httpx.Response( @@ -153,8 +152,7 @@ def test_decoders_empty_cases(header_value): @pytest.mark.parametrize("header_value", (b"deflate", b"gzip", b"br")) def test_decoding_errors(header_value): headers = [(b"Content-Encoding", header_value)] - body = b"test 123" - compressed_body = brotli.compress(body)[3:] + compressed_body = b"invalid" with pytest.raises(httpx.DecodingError): request = httpx.Request("GET", "https://example.org") httpx.Response(200, headers=headers, content=compressed_body, request=request)