encode/httpx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop Host header for HTTP/2 (#82)

Browse Source
This commit is contained in:
Tom Christie 2019-05-28 14:39:57 +01:00 committed by GitHub
parent 9d19adba30
commit 76bc6c6dea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
httpcore/dispatch/http11.py
View File

@ -46,6 +46,9 @@ class HTTP11Connection:
method = request.method.encode("ascii")
target = request.url.full_path.encode("ascii")
headers = request.headers.raw
if 'Host' not in request.headers:
host = request.url.authority.encode("ascii")
headers = [(b"host", host)] + headers
event = h11.Request(method=method, target=target, headers=headers)
await self._send_event(event, timeout)

3
httpcore/models.py
View File

@ -523,14 +523,11 @@ class Request:
def prepare(self) -> None:
auto_headers = [] # type: typing.List[typing.Tuple[bytes, bytes]]
has_host = "host" in self.headers
has_content_length = (
"content-length" in self.headers or "transfer-encoding" in self.headers
)
has_accept_encoding = "accept-encoding" in self.headers
if not has_host and self.url.authority:
auto_headers.append((b"host", self.url.authority.encode("ascii")))
if not has_content_length:
if self.is_streaming:
auto_headers.append((b"transfer-encoding", b"chunked"))

10
tests/models/test_requests.py
View File

@ -8,11 +8,11 @@ def test_request_repr():
assert repr(request) == "<Request('GET', 'http://example.org')>"
def test_host_header():
def test_no_content():
request = httpcore.Request("GET", "http://example.org")
request.prepare()
assert request.headers == httpcore.Headers(
[(b"host", b"example.org"), (b"accept-encoding", b"deflate, gzip, br")]
[(b"accept-encoding", b"deflate, gzip, br")]
)
@ -21,7 +21,6 @@ def test_content_length_header():
request.prepare()
assert request.headers == httpcore.Headers(
[
(b"host", b"example.org"),
(b"content-length", b"8"),
(b"accept-encoding", b"deflate, gzip, br"),
]
@ -33,7 +32,6 @@ def test_url_encoded_data():
request.prepare()
assert request.headers == httpcore.Headers(
[
(b"host", b"example.org"),
(b"content-length", b"8"),
(b"accept-encoding", b"deflate, gzip, br"),
(b"content-type", b"application/x-www-form-urlencoded"),
@ -52,7 +50,6 @@ def test_transfer_encoding_header():
request.prepare()
assert request.headers == httpcore.Headers(
[
(b"host", b"example.org"),
(b"transfer-encoding", b"chunked"),
(b"accept-encoding", b"deflate, gzip, br"),
]
@ -75,7 +72,7 @@ def test_override_accept_encoding_header():
request = httpcore.Request("GET", "http://example.org", headers=headers)
request.prepare()
assert request.headers == httpcore.Headers(
[(b"host", b"example.org"), (b"accept-encoding", b"identity")]
[(b"accept-encoding", b"identity")]
)
@ -90,7 +87,6 @@ def test_override_content_length_header():
request.prepare()
assert request.headers == httpcore.Headers(
[
(b"host", b"example.org"),
(b"accept-encoding", b"deflate, gzip, br"),
(b"content-length", b"8"),
]